Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Narendra Modi - Text Speeches Analysis #702

Closed
wants to merge 6 commits into from

Conversation

HarshRaj29004
Copy link
Contributor

Pull Request for ML-Crate 💡

Issue Title: Narendra Modi - Text Speeches Analysis

  • Info about the related issue (Aim of the project) : This project is to analyze the speeches of Narendra Modi.
  • Name: Harsh Raj
  • Email ID for further communication:
  • GitHub ID:
  • Idenitfy yourself: SSOC'24 participant

Closes: #127

Describe the add-ons or changes you've made 📃

Give a clear description of what have you added or modifications made

Type of change ☑️

What sort of change have you made:
** Analysis the speeches as per in the dataset and concluded few of the points from it.**

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

Describe how it has been tested
Describe how have you verified the changes made

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Copy link

github-actions bot commented Jul 8, 2024

Our team will soon review your PR. Thanks @HarshRaj29004 :)

@HarshRaj29004
Copy link
Contributor Author

HarshRaj29004 commented Jul 8, 2024

Major changes were done in the duration of cloning. Few of the files were showing errors.

@abhisheks008
Copy link
Owner

image

You shouldn't have updated the existing files.

@abhisheks008 abhisheks008 added Requested Changes ⚙️ Some changes have been requested in this PR. SSOC labels Jul 12, 2024
@HarshRaj29004
Copy link
Contributor Author

I have restored some deleted png files and none file have been modified.

@abhisheks008
Copy link
Owner

Hi @HarshRaj29004 but in GitHub it's showing that you might have done some updates to the existing projects. It might occur if you are not pushing your code in the latest forked repository. It'll be better if you create a fresh PR for the same with the latest forked repository.

@HarshRaj29004
Copy link
Contributor Author

Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Requested Changes ⚙️ Some changes have been requested in this PR. SSOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Narendra Modi - Text Speeches Analysis
2 participants