Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVD Dataset Analysis #708

Merged
merged 3 commits into from
Jul 14, 2024
Merged

CVD Dataset Analysis #708

merged 3 commits into from
Jul 14, 2024

Conversation

arijitde92
Copy link
Contributor

Added CVD Dataset Analysis Code

Pull Request for ML-Crate 💡

Issue Title: CVD Dataset Analysis #649

  • Info about the related issue (Aim of the project) : To predict cardio vascular disease risk.
  • Name: Arijit De
  • Email ID for further communication: arijitde2050@gmail.com
  • GitHub ID: arijitde92
  • Idenitfy yourself: VSOC'24

Closes: #649

Describe the add-ons or changes you've made 📃

Give a clear description of what have you added or modifications made

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

Describe how it has been tested
By creating training and testing sets randomly in the ratio 80:20 respectively and testing some models on the test set.
Describe how have you verified the changes made
By comparing with various Machine Learning models with a variety of metrics.

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Added CVD Dataset Analysis Code
Copy link

Our team will soon review your PR. Thanks @arijitde92 :)

@abhisheks008 abhisheks008 changed the title CVD Dataset Analysis #649 CVD Dataset Analysis Jul 14, 2024
Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Remove the .vscode folder.
  2. Inside the Model/README file, typing mistakes are there in the project name. Eg. pCardio Vascular Disease....
  3. Mention the accuracy scores of the models inside the README.
  4. Add requirements.txt file.
  5. Insert the EDA results inside the README too.

@arijitde92 please fix these issues ASAP.

@abhisheks008 abhisheks008 added Requested Changes ⚙️ Some changes have been requested in this PR. VSoC’24 Vinyasa Summer of Code (VSOC) labels Jul 14, 2024
@arijitde92
Copy link
Contributor Author

Hi @abhisheks008 , I have made the requested changes, please review the PR.
I have added the EDA plots in the README.md along with the dataset description. Let me know if anything else is required to be inserted into the README.md as part of the EDA results.

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @arijitde92 looks good to me. Approved ✅

@abhisheks008 abhisheks008 added Approved ✅ This PR is approved by the PR or, Mentors. MEDIUM VSOC - 10 Points and removed Requested Changes ⚙️ Some changes have been requested in this PR. labels Jul 14, 2024
@abhisheks008 abhisheks008 merged commit 6d2d3bc into abhisheks008:main Jul 14, 2024
@abhisheks008 abhisheks008 added the Points Added 🎉 This issue's points has been added to the leaderboard. label Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved ✅ This PR is approved by the PR or, Mentors. MEDIUM VSOC - 10 Points Points Added 🎉 This issue's points has been added to the leaderboard. VSoC’24 Vinyasa Summer of Code (VSOC)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CVD Dataset Analysis
2 participants