Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Narendra Modi - Text Speech Analysis #713

Merged
merged 4 commits into from
Jul 21, 2024

Conversation

HarshRaj29004
Copy link
Contributor

Pull Request for ML-Crate 💡

Issue Title: Narendra Modi - Text Speech Analysis

  • Info about the related issue (Aim of the project) : This project is to analyze the speeches of Narendra Modi.
  • Name: Harsh Raj
  • Email ID for further communication: hr768381@gmail.com
  • GitHub ID: https://github.com/HarshRaj29004
  • Idenitfy yourself: SSOC'24 participant

Closes: #127

Describe the add-ons or changes you've made 📃

Give a clear description of what have you added or modifications made

Type of change☑️

What sort of change have you made:
** Analyzed the speeches as per in the dataset and concluded few of the points from it.**

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

Describe how it has been tested
Describe how have you verified the changes made

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Copy link

Our team will soon review your PR. Thanks @HarshRaj29004 :)

@HarshRaj29004
Copy link
Contributor Author

I renamed two image folders to rectify errors(just removed ':'). Changing of name does not affect any other files.

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the README template and update the file. Here it is, https://github.com/abhisheks008/ML-Crate/blob/main/.github/readme_template.md

@abhisheks008 abhisheks008 added Requested Changes ⚙️ Some changes have been requested in this PR. SSOC labels Jul 20, 2024
@HarshRaj29004
Copy link
Contributor Author

I have updated the Readme

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR is approved and ready to be merged.
@HarshRaj29004

@abhisheks008 abhisheks008 added Approved ✅ This PR is approved by the PR or, Mentors. Intermediate Points 30 - SSOC 2024 and removed Requested Changes ⚙️ Some changes have been requested in this PR. labels Jul 21, 2024
@abhisheks008 abhisheks008 merged commit 924825e into abhisheks008:main Jul 21, 2024
@abhisheks008 abhisheks008 added the Points Added 🎉 This issue's points has been added to the leaderboard. label Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved ✅ This PR is approved by the PR or, Mentors. Intermediate Points 30 - SSOC 2024 Points Added 🎉 This issue's points has been added to the leaderboard. SSOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Narendra Modi - Text Speeches Analysis
2 participants