Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fictional character battle #721

Merged
merged 5 commits into from
Jul 27, 2024

Conversation

adi271001
Copy link
Contributor

Pull Request for ML-Crate 💡

Issue Title: #689

  • Info about the related issue (Aim of the project) : to predict the battle outcome between fictional characters
  • Name: Aditya D
  • Email ID for further communication: ibetanibex@gmail.com
  • GitHub ID: https://www.github.com/adi271001
  • Idenitfy yourself: SSOC Contributor

Closes: #issue number that will be closed through this PR #689

Describe the add-ons or changes you've made 📃

Give a clear description of what have you added or modifications made
Added all the required model files , readmes , images , dataset , image files.

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

Describe how it has been tested
Describe how have you verified the changes made
Divided data into test and train dataset , plotted graphs for checking under and over fitting

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Copy link

Our team will soon review your PR. Thanks @adi271001 :)

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Approved @adi271001

@abhisheks008 abhisheks008 linked an issue Jul 27, 2024 that may be closed by this pull request
@abhisheks008 abhisheks008 added Approved ✅ This PR is approved by the PR or, Mentors. Advanced Points 40 - SSOC 2024 SSOC labels Jul 27, 2024
@abhisheks008 abhisheks008 merged commit 63ed015 into abhisheks008:main Jul 27, 2024
1 check passed
@abhisheks008 abhisheks008 added the Points Added 🎉 This issue's points has been added to the leaderboard. label Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Advanced Points 40 - SSOC 2024 Approved ✅ This PR is approved by the PR or, Mentors. Points Added 🎉 This issue's points has been added to the leaderboard. SSOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fictional Character Battle Outcome Prediction
2 participants