Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameters of Cricket Analysis #726

Merged
merged 5 commits into from
Aug 3, 2024
Merged

Parameters of Cricket Analysis #726

merged 5 commits into from
Aug 3, 2024

Conversation

SOMNATH0904
Copy link
Contributor

Pull Request for ML-Crate 💡

Issue Title: Parameters of Cricket Analysis #723

Closes: #723

Describe the add-ons or changes you've made 📃

It is a comprehensive guide for conducting EDA on sports-related datasets. It aims to equip users with the skills necessary to uncover insights and patterns from raw data, leveraging various statistical and graphical techniques. This project covers a range of essential EDA steps, including data cleaning, data visualization, and summary statistics. Users will learn how to handle missing values, identify outliers, and understand the distribution and relationships within the data.

Type of change ☑️

New Project added.

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

The files are updated.
Describe how it has been tested
Describe how have you verified the changes made

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Copy link

Our team will soon review your PR. Thanks @SOMNATH0904 :)

@SOMNATH0904
Copy link
Contributor Author

@abhisheks008 Please Check this !!

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @SOMNATH0904 please follow the project structure and update the project files accordingly.

@abhisheks008 abhisheks008 added Requested Changes ⚙️ Some changes have been requested in this PR. SSOC labels Aug 2, 2024
@SOMNATH0904
Copy link
Contributor Author

Hi @SOMNATH0904 please follow the project structure and update the project files accordingly.

@abhisheks008 I have updated the files according to the project structure. Can you please take a review ? ...

@abhisheks008 abhisheks008 changed the title Added all the files Parameters of Cricket Analysis Aug 3, 2024
Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow the README template and update the Model/README file, https://github.com/abhisheks008/ML-Crate/blob/main/.github/readme_template.md

@SOMNATH0904

@SOMNATH0904
Copy link
Contributor Author

@abhisheks008 Please check now!!

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Approved ✅
@SOMNATH0904

@abhisheks008 abhisheks008 added Approved ✅ This PR is approved by the PR or, Mentors. Intermediate Points 30 - SSOC 2024 and removed Requested Changes ⚙️ Some changes have been requested in this PR. labels Aug 3, 2024
@abhisheks008 abhisheks008 merged commit e15277c into abhisheks008:main Aug 3, 2024
@abhisheks008 abhisheks008 added the Points Added 🎉 This issue's points has been added to the leaderboard. label Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved ✅ This PR is approved by the PR or, Mentors. Intermediate Points 30 - SSOC 2024 Points Added 🎉 This issue's points has been added to the leaderboard. SSOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parameters of Cricket Analysis
2 participants