Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release snapshots workflow #1287

Merged
merged 21 commits into from
May 7, 2024
Merged

Add release snapshots workflow #1287

merged 21 commits into from
May 7, 2024

Conversation

asl
Copy link
Member

@asl asl commented May 1, 2024

Few changes here and there as well

@asl asl requested a review from andrewprzh May 1, 2024 01:00
@asl asl marked this pull request as draft May 6, 2024 18:31
@asl asl force-pushed the release-manylinux branch 5 times, most recently from 91eea08 to 598f470 Compare May 6, 2024 19:54
@asl asl marked this pull request as ready for review May 6, 2024 20:47
@asl
Copy link
Member Author

asl commented May 6, 2024

We upload snashots to releases now. @andrewprzh Ready for re-review

Copy link
Collaborator

@andrewprzh andrewprzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one real question about static that's all to clarify

.github/workflows/basic.yml Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
@andrewprzh andrewprzh self-requested a review May 7, 2024 16:27
@asl asl merged commit b093c73 into next May 7, 2024
92 checks passed
@asl asl deleted the release-manylinux branch May 7, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants