Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ably-js v2 migration #17

Merged
merged 8 commits into from
May 29, 2024
Merged

Ably-js v2 migration #17

merged 8 commits into from
May 29, 2024

Conversation

VeskeR
Copy link
Contributor

@VeskeR VeskeR commented May 17, 2024

Updates this project to use ably-js v2 so it matches updated code samples in related blog post: https://ably.com/blog/next-js-vercel-link-sharing-serverless-websockets

@VeskeR VeskeR requested a review from ttypic May 17, 2024 08:32
@VeskeR VeskeR force-pushed the ably-v2-migration branch from e50d681 to 4ef83d7 Compare May 17, 2024 11:53
Copy link

@ttypic ttypic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, added couple of minor suggestions

components/Articles.js Outdated Show resolved Hide resolved
yarn.lock Outdated Show resolved Hide resolved
No need to use both `yarn.lock` and `package-lock.json` and we prefer
to have `package-lock.json`.
@VeskeR VeskeR force-pushed the ably-v2-migration branch from 4ef83d7 to f74b874 Compare May 24, 2024 03:24
@VeskeR VeskeR changed the base branch from main to add-formatting May 24, 2024 03:24
@VeskeR
Copy link
Contributor Author

VeskeR commented May 24, 2024

@ttypic Removed yarn.lock in this PR and updated formatting in #18 PR. This PR is now based on that formatting PR so please review that one too, thank you!

@VeskeR VeskeR force-pushed the ably-v2-migration branch from f74b874 to 2630387 Compare May 24, 2024 03:34
Base automatically changed from add-formatting to main May 29, 2024 00:58
Previous link to the guide for resolving merge conflicts in github no
longer exist, so replaced with the next best tutorial from github docs.
@VeskeR VeskeR merged commit 3b0de24 into main May 29, 2024
2 checks passed
@VeskeR VeskeR deleted the ably-v2-migration branch May 29, 2024 01:08
@VeskeR VeskeR restored the ably-v2-migration branch July 15, 2024 13:15
@VeskeR VeskeR deleted the ably-v2-migration branch July 15, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants