-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ECO-5013][CHA-RL4] Thread safe async emitter #38
[ECO-5013][CHA-RL4] Thread safe async emitter #38
Conversation
sacOO7
commented
Oct 26, 2024
•
edited
Loading
edited
- Implemented thread-safe async event emitter
- This is mainly needed for the internal room lifecycle, where we need to listen to channel emitted events ( monitor channel lifecycle events), emitted events should be processed sequentially in the specified scope.
- Implementation can be modified in the future to handle external listeners, events etc
- We do not use observables here ( like flow collectors) , so no need to handle the closure of resources or memory leak issues.
- This is a better alternative to [ECO-5013][CHA-RL4] Flow based Event Emitter #35
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
2cdbdb3
to
9f5d933
Compare
9f5d933
to
bd72b74
Compare
single threaded access
refactored scoped used by AsyncSubscriber
0abcc58
to
9f90fd5
Compare
d2e1f1a
to
3cedc57
Compare
…sert.Fail Helps with debugging the failed assertion statement
e1b4ed6
to
2c28e5a
Compare
…sync-emitter # Conflicts: # chat-android/src/test/java/com/ably/chat/TestUtils.kt
Marking this as closed.. PR contents will be used for #25 |