Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish to new CDN bucket only #1460

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Conversation

surminus
Copy link
Contributor

@surminus surminus commented Oct 5, 2023

We've finally migrated to the new bucket, so we can stop publishing to the old bucket, which I intend to delete.

@surminus surminus requested review from lmars and owenpearson October 5, 2023 11:17
@github-actions github-actions bot temporarily deployed to staging/pull/1460/features October 5, 2023 11:17 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1460/bundle-report October 5, 2023 11:19 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1460/typedoc October 5, 2023 11:19 Inactive
Copy link
Member

@owenpearson owenpearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but we should also update the bucket name in scripts/README.md

We've finally migrated to the new bucket, so we can stop publishing to
the old bucket, which I intend to delete.
@surminus surminus force-pushed the laura-delete-old-cdn-bucket branch from 3969e4a to 7c59b7d Compare October 5, 2023 11:21
@surminus
Copy link
Contributor Author

surminus commented Oct 5, 2023

Thanks @owenpearson, updated

Copy link
Member

@owenpearson owenpearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@surminus
Copy link
Contributor Author

surminus commented Oct 5, 2023

@owenpearson, can you merge? I am not authorized to do so 😢

@owenpearson owenpearson merged commit 83b4516 into main Oct 5, 2023
11 checks passed
@owenpearson owenpearson deleted the laura-delete-old-cdn-bucket branch October 5, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants