Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic height for table #606

Merged
merged 3 commits into from
Oct 18, 2023

Conversation

OmkarPh
Copy link
Collaborator

@OmkarPh OmkarPh commented Oct 5, 2023

Fixes #598

Applies auto height for

  • License explorer - Matches & File region tables
  • Package explorer - Dependencies table
  • Dependency Info dashboard - Dependency scope summary table

Not affecting Tableview, as its expected to be a full screen view

Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
@OmkarPh OmkarPh linked an issue Oct 5, 2023 that may be closed by this pull request
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks++ @OmkarPh
Adding some really minor UI suggestions for your consideration, otherwise please merge.

  1. In the dependencies table in Package Explorer, the row height seems to be a bit too much. This is because of long data file paths, and we should probably have a wider default width for this, to make the row height smaller.
  2. Consider the case where we detect packages but no dependencies, in this case the Dependency Scope summary by Package Type table should not have entries with each package type in the row, but all values as zero. We should show a No Dependencies instead.

…ble dimensions

Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
@OmkarPh
Copy link
Collaborator Author

OmkarPh commented Oct 17, 2023

  1. In the dependencies table in Package Explorer, the row height seems to be a bit too much. This is because of long data file paths, and we should probably have a wider default width for this, to make the row height smaller.
  2. Consider the case where we detect packages but no dependencies, in this case the Dependency Scope summary by Package Type table should not have entries with each package type in the row, but all values as zero. We should show a No Dependencies instead.

Thanks for the suggestions,
I've incorporated these changes

@AyanSinhaMahapatra
Copy link
Member

Thanks @OmkarPh , merging!

@AyanSinhaMahapatra AyanSinhaMahapatra merged commit d21e55d into feature/unittests Oct 18, 2023
7 checks passed
@AyanSinhaMahapatra AyanSinhaMahapatra deleted the fix/autoTableDimensions branch October 18, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fit table height & column widths to requirement
2 participants