Send DNS information from the server HTTPS response to the system using resolvconf #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
June 25, 2020 18:10
I found that the space after the = was missing in one line, which produced a parse error (the line was dnsSuffixes =foo). This change makes the parser work on this and similar whitespace variations
Funcationally the same, but all the code related to DNS set and cleanup is now in a class of it's own, which is dependency injected so that someone could write a version to directy manipulate /etc/resolv.conf if they are feeling masochistic.
Turns out a lot of code here is the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #14 in the situation where:
It is activated by a command line option, which is off by default.