Reverted to the version of audio_pipe.c prior to the last major change and used a different method to open the pipe for writing. #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and used a different method to open the pipe for writing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using shairport with forked-daapd. The prior changes submitted by ejurgensen were not reliable for me. After starting a couple AirPlay streams, shairport would become unresponsive, and I would have to restart it. I reverted to the prior version of audio_pipe.c and made changes. To achieve the functionality that ejurgensen added, I first open the pipe for reading, opening it for writing, and then close the read fd. I have been using this for a couple weeks with no issues.
This is my first attempt at using git and GitHub, so I apologize if I haven't made this request properly.