Feature/add tests to rate limiting code and resolve any bugs #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* time comparison was incorrect * makes private method names less confusing
* should intialise multiple threads simultaneously
|
Thank you for this fix. I observed the same issue mentioned in issue #815 - deadlock in WaitForPermittedRequest I have cherry picked this change in my project and can confirm that it appears to have resolved this issue without averse changes. Thank you again for the continued maintenance of this project, it is extremely useful! |
abuzuhri
approved these changes
Jan 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you to all who brought this to my attention on #815 and #812.
This contains fix for an issue in which rate limiting caused an infinite wait when the burst was reached, and introduces a unit test project