Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fnd api #605

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from
Open

fix fnd api #605

wants to merge 8 commits into from

Conversation

wjeongchoi
Copy link
Contributor

@wjeongchoi wjeongchoi commented Aug 14, 2024

요약 *

It closes #601

확인할 사항

  • file repository의 findById에 isNull(deletedAt)이 안 붙어있는데 괜찮은지
  • put에서 file 삭제하고 다시 올릴 때 file이 원래 없었던 항목의 경우 affectedRows로 삭제가 제대로 되었는지 확인하는 부분에서 에러가 생김. 삭제 확인을 하기 위해 기존 funding 정보를 받아오는 부분을 추가할 것인지, 아니면 그냥 삭제 잘 됐는지 확인하는 부분을 뺄 것인지

001

스크린샷 2024-08-14 오후 7 07 26 스크린샷 2024-08-14 오후 7 07 49

002

스크린샷 2024-08-14 오후 1 40 34

003

image

스크린샷

이후 Task *

  • file upload 확인

@wjeongchoi wjeongchoi added bug Something isn't working back-end labels Aug 14, 2024
@wjeongchoi wjeongchoi self-assigned this Aug 14, 2024
@wjeongchoi wjeongchoi linked an issue Aug 14, 2024 that may be closed by this pull request
2 tasks
Copy link

netlify bot commented Aug 14, 2024

Deploy Preview for jazzy-klepon-c756b5 ready!

Name Link
🔨 Latest commit 7a502f2
🔍 Latest deploy log https://app.netlify.com/sites/jazzy-klepon-c756b5/deploys/66c303b78fe6cd0008b9d02d
😎 Deploy Preview https://deploy-preview-605--jazzy-klepon-c756b5.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 58
Accessibility: 100
Best Practices: 100
SEO: 92
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@wjeongchoi wjeongchoi marked this pull request as ready for review August 19, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back-end bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix fnd api
1 participant