Implement a usage-order selection of common spaces #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for jazzy-klepon-c756b5 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Engineer-JJHaMa
changed the title
Engineer-JJHaMa
requested changes
Aug 21, 2024
Comment on lines
+171
to
+181
| @Get("student/common-spaces/common-space/usage-order/:orderId") | ||
| @UsePipes(new ZodPipe(apiCms008)) | ||
| async getStudentCommonSpacesUsageOrderDetail( | ||
| @Param() param: ApiCms008RequestParam, | ||
| ): Promise<ApiCms008ResponseOk> { | ||
| const result = | ||
| await this.commonspaceService.getStudentCommonSpacesUsageOrderDetail( | ||
| param.orderId, | ||
| ); | ||
| return result; | ||
| } |
There was a problem hiding this comment.
❗ CMS-008은 사용자가 해당 신청의 신청자이거나 신청 동아리의 대표자+대의원인지 검사합니다. 이를 위해 토큰으로부터 유저 정보를 가져와야해요. GetStudent의 사용 예시를 보고 적용해주세요
| await this.commonSpaceUsageOrderDRepository.findCommonSpaceUsageOrderById( | ||
| orderId, | ||
| ); | ||
| // const { id } = order; |
There was a problem hiding this comment.
❗ 아마 요근처에서 권한 확인이 들어가야 할 것 같네요
|
|
||
| const responseBodyMap = { | ||
| [HttpStatusCode.Ok]: z.object({ | ||
| orderId: z.number().int().min(1), |
There was a problem hiding this comment.
💬 Reponse는 coerce가 필요 없는지 확인이 필요합니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요약 *
It closes #604
스크린샷
CMS-008 API
이후 Task *