Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Alias Import #20

Merged
merged 10 commits into from
Jul 4, 2024
Merged

feat: Alias Import #20

merged 10 commits into from
Jul 4, 2024

Conversation

salujajaskeerat
Copy link
Contributor

@salujajaskeerat salujajaskeerat commented May 28, 2024 •
edited
Loading

Closes #19

Changes

  • Added concept for AliasTypes.
  • MetaModelutil updated to handle the aliased types
  • added test-cases using aliased types

Related Issues

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

@salujajaskeerat
feat: Concept for alias import added
49158e4 
Signed-off-by: Jaskeerat Singh Saluja <58400083+salujajaskeerat@users.noreply.github.com>
@salujajaskeerat salujajaskeerat changed the title feat: Aias Import feat: Alias Import May 28, 2024
ekarademir
ekarademir reviewed May 28, 2024
View reviewed changes
lib/metamodel.cto Outdated Show resolved Hide resolved
@ekarademir
Copy link
Contributor

If you put 19 after Closes # then the ticket that is being referenced will close automatically after you get this merged.

@salujajaskeerat
feat: metamodel.json updated for alias imports
90c70f2 
Signed-off-by: Jaskeerat Singh Saluja <58400083+salujajaskeerat@users.noreply.github.com>
salujajaskeerat
salujajaskeerat commented May 29, 2024
View reviewed changes
lib/metamodel.cto Outdated Show resolved Hide resolved
@salujajaskeerat
fix: concept ImportAliasTypes merged into ImportTypes
1f77cd9 
Signed-off-by: Jaskeerat Singh Saluja <58400083+salujajaskeerat@users.noreply.github.com>
ekarademir
ekarademir requested changes Jun 11, 2024
View reviewed changes
lib/metamodel.cto Outdated Show resolved Hide resolved
@ekarademir
Copy link
Contributor

Also please add tests for these, if possible.

@salujajaskeerat
feat(alias): variable renamed and test cases added
7aba6de 
Signed-off-by: Jaskeerat Singh Saluja <58400083+salujajaskeerat@users.noreply.github.com>
@salujajaskeerat
feat(alias import): metamodelutil updated
240e917 
- Test cases added
- metamodelfile.js updated for aliased imports

Signed-off-by: Jaskeerat Singh Saluja <58400083+salujajaskeerat@users.noreply.github.com>
@salujajaskeerat
feat(alias import): test cases updated
79390b4 
Signed-off-by: Jaskeerat Singh Saluja <58400083+salujajaskeerat@users.noreply.github.com>
ekarademir
ekarademir approved these changes Jul 2, 2024
View reviewed changes
test/cto/aliasedImportResolved.json Outdated Show resolved Hide resolved
test/metamodelutil.js Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Jul 2, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9756365869

Details

  • 11 of 13 (84.62%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.2%) to 92.486%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/metamodelutil.js 11 13 84.62%
Totals Coverage Status
Change from base Build 9131851457: -1.2%
Covered Lines: 100
Relevant Lines: 104
💛 - Coveralls

@salujajaskeerat
feat(alias import): Pr changes
9a19b1a 
Signed-off-by: Jaskeerat Singh Saluja <58400083+salujajaskeerat@users.noreply.github.com>
@coveralls
Copy link

coveralls commented Jul 3, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9757687099

Details

  • 11 of 13 (84.62%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.2%) to 92.486%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/metamodelutil.js 11 13 84.62%
Totals Coverage Status
Change from base Build 9131851457: -1.2%
Covered Lines: 100
Relevant Lines: 104
💛 - Coveralls

@salujajaskeerat
feat(import alias): Code refactored & Test Coverage
b035bbd 
- metamodelutil.js code refactored
- Test cases updated to increase coverage

Signed-off-by: Jaskeerat Singh Saluja <58400083+salujajaskeerat@users.noreply.github.com>
@salujajaskeerat
feat(alias): Test case fixed
fb84212 
Signed-off-by: Jaskeerat Singh Saluja <58400083+salujajaskeerat@users.noreply.github.com>
@coveralls
Copy link

coveralls commented Jul 4, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9790485204

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.5%) to 95.122%
Totals Coverage Status
Change from base Build 9131851457: 1.5%
Covered Lines: 95
Relevant Lines: 97
💛 - Coveralls

@salujajaskeerat
feat(alias):code refactored & comments added
1f6bc61 
Signed-off-by: Jaskeerat Singh Saluja <58400083+salujajaskeerat@users.noreply.github.com>
@coveralls
Copy link

coveralls commented Jul 4, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9791020660

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.5%) to 95.152%
Totals Coverage Status
Change from base Build 9131851457: 1.5%
Covered Lines: 96
Relevant Lines: 98
💛 - Coveralls

@ekarademir ekarademir merged commit 9eeb019 into accordproject:main Jul 4, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekarademir ekarademir ekarademir approved these changes

@mttrbrts mttrbrts mttrbrts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: add Import Alias types to metamodel
4 participants
@salujajaskeerat @ekarademir @coveralls @mttrbrts