Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build by adding /v4 to module path #260

Closed
wants to merge 2 commits into from

Conversation

yonas
Copy link

@yonas yonas commented Dec 17, 2023

Copy link
Owner

@achannarasappa achannarasappa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request! I've added a few comments

Also please rebase with master. I've fixed the linting and test errors that were present when this branch was originally created so you should be able to get clearer automated feedback on the PR.

@@ -1,8 +1,8 @@
<p>
<a href="https://github.com/achannarasappa/ticker/releases"><img src="https://img.shields.io/github/v/release/achannarasappa/ticker" alt="Latest Release"></a>
<a href="https://github.com/achannarasappa/ticker/actions"><img src="https://github.com/achannarasappa/ticker/workflows/test/badge.svg" alt="Build Status"></a>
<a href="https://github.com/achannarasappa/ticker/v4/releases"><img src="https://img.shields.io/github/v/release/achannarasappa/ticker" alt="Latest Release"></a>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

URLs in the readme should remain without a /v4/

@@ -62,7 +62,7 @@ brews:
commit_author:
name: achannarasappa
email: git@ani.dev
homepage: "https://github.com/achannarasappa/ticker"
homepage: "https://github.com/achannarasappa/ticker/v4"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This URL should remain without a /v4/

@@ -115,7 +115,7 @@ nfpms:
file_name_template: "{{ .ProjectName }}-{{ .Version }}-{{ .Os }}-{{ .Arch }}{{ if .Arm }}v{{ .Arm }}{{ end }}{{ if .Mips }}-{{ .Mips }}{{ end }}"
builds:
- build-linux-64
homepage: https://github.com/achannarasappa/ticker
homepage: https://github.com/achannarasappa/ticker/v4
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This URL should remain without a /v4/

@@ -15,7 +15,7 @@ builds:
post:
- upx "{{ .Path }}"
ldflags:
- -s -w -X 'github.com/achannarasappa/ticker/cmd.Version={{.Version}}'
- -s -w -X 'github.com/achannarasappa/ticker/v4/cmd.Version={{.Version}}'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure these should remain with a /v4/ but not certain. Have you run a test build to confirm this should be here?

@clausecker
Copy link

Any progress on this one?

@achannarasappa
Copy link
Owner

achannarasappa commented Jun 2, 2024

I think there might be some other issue causing problem here with go install but I've updated the module path in this commit.

@yonas yonas deleted the yonasBSD branch June 2, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants