Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding omg.lol DNS API #5301

Merged
merged 11 commits into from
Oct 6, 2024
Merged

Adding omg.lol DNS API #5301

merged 11 commits into from
Oct 6, 2024

Conversation

as-kholin
Copy link
Contributor

DNS API for omg.lol.

Fixes #4466 .

Bug Report issue: #5299
API Wiki Entry: https://github.com/acmesh-official/acme.sh/wiki/dnsapi2#dns_omglol

Copy link

Welcome
First thing: don't send PR to the master branch, please send to the dev branch instead.
Please make sure you've read our DNS API Dev Guide and DNS-API-Test.
Then reply on this message, otherwise, your code will not be reviewed or merged.
We look forward to reviewing your Pull request shortly ✨
注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

@as-kholin
Copy link
Contributor Author

Reviewed both API dev guide and API Test documentation, and believe I am following them consistently.

dnsapi/dns_omglol.sh Outdated Show resolved Hide resolved
dnsapi/dns_omglol.sh Outdated Show resolved Hide resolved
dnsapi/dns_omglol.sh Outdated Show resolved Hide resolved
@as-kholin as-kholin marked this pull request as draft September 29, 2024 20:40
@as-kholin as-kholin marked this pull request as ready for review September 30, 2024 11:48
@as-kholin as-kholin marked this pull request as draft September 30, 2024 13:45
@as-kholin as-kholin marked this pull request as ready for review September 30, 2024 18:21
@as-kholin
Copy link
Contributor Author

Sorry for the multiple moves back to draft - found a test issue, and was correcting it (and ensuring it was corrected).

@Neilpang
Copy link
Member

Neilpang commented Oct 4, 2024

@as-kholin
Copy link
Contributor Author

update the variable names in: https://github.com/acmesh-official/acme.sh/wiki/dnsapi2#dns_omglol #5299

Updated

@Neilpang Neilpang merged commit f6698d4 into acmesh-official:dev Oct 6, 2024
13 checks passed
@as-kholin as-kholin deleted the dns_omglol branch October 25, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants