Script to update package.yml using dependabot #641
+157
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+23
to
+47
| function get_latest_version($packageName) { | ||
| $client = new Client(); | ||
| $url = "https://repo.packagist.org/p/{$packageName}.json"; | ||
|
|
||
| try { | ||
| $response = $client->get($url); | ||
| $data = json_decode($response->getBody(), TRUE); | ||
|
|
||
| $versions = array_keys($data['packages'][$packageName]); | ||
| usort($versions, 'version_compare'); | ||
|
|
||
| $latestVersion = end($versions); | ||
|
|
||
| // Extract major.minor version (e.g., "13.3.3" becomes "13.x") | ||
| $versionParts = explode('.', $latestVersion); | ||
| if (count($versionParts) > 1) { | ||
| return $versionParts[0] . '.x'; | ||
| } | ||
|
|
||
| return NULL; | ||
| } | ||
| catch (RequestException $e) { | ||
| return get_latest_version_from_drupal_org($packageName); | ||
| } | ||
| } |
There was a problem hiding this comment.
This would be much more readable if you would extract the Packagist part this into a separate function just like you did with get_latest_version_from_drupal_org(). Consider how much clearer this would be, for example:
function get_latest_version($packageName) {
return get_latest_version_from_packagist($packageName)
?? get_latest_version_from_drupal_org($packageName);
}| * @return string|null | ||
| * The latest version string, or NULL if not found. | ||
| */ | ||
| function get_latest_version($packageName) { |
There was a problem hiding this comment.
Suggested change
| function get_latest_version($packageName) { | |
| function get_latest_version(string $packageName) { |
| * @return string|null | ||
| * The latest version string, or NULL if not found. | ||
| */ | ||
| function get_latest_version_from_drupal_org($packageName) { |
There was a problem hiding this comment.
Suggested change
| function get_latest_version_from_drupal_org($packageName) { | |
| function get_latest_version_from_drupal_org(string $packageName) { |
| * @return bool | ||
| * TRUE if it is a major update, FALSE otherwise. | ||
| */ | ||
| function is_major_update($currentVersion, $latestVersion) { |
There was a problem hiding this comment.
Suggested change
| function is_major_update($currentVersion, $latestVersion) { | |
| function is_major_update(?string $currentVersion, ?string $latestVersion) { |
| * @param string $filePath | ||
| * The path to the YAML file. | ||
| */ | ||
| function update_packages_yaml($filePath) { |
There was a problem hiding this comment.
Suggested change
| function update_packages_yaml($filePath) { | |
| function update_packages_yaml(string $filePath) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.