Merge pull request #214 from taskrabbit/empty-namespace

allow for empty namespaces

README.md

@@ -7,7 +7,7 @@
 [![Build Status](https://secure.travis-ci.org/taskrabbit/node-resque.png?branch=master)](http://travis-ci.org/taskrabbit/node-resque)
 
 ## Version Notes
-* ‼️ Version 6+ of Node Resque uses async/await.  There is no upgrade path from previous versions.  Node v8.0.0+ is required.
+* ‼️ Version 5+ of Node Resque uses async/await.  There is no upgrade path from previous versions.  Node v8.0.0+ is required.
 
 ## Usage
 

changelog

@@ -1,6 +1,7 @@
 - dropped support for fakeredis; you must use a redis connection which supports promises
 - async!!!
 - capitol names for all classes
-- plugin lifecycles are now cammel case: beforeEnqueue, afterEnqueue, beforePerform, afterPerform
+- plugin lifecycles are now camel case: beforeEnqueue, afterEnqueue, beforePerform, afterPerform
 - plugin lifecycle methods are now async methods, with no callback
 - plugins now inherit from NodeResque.Plugin
+- allow for empty/null namespaces (to match sidekiq's default)

lib/connection.js

@@ -81,6 +81,7 @@ class Connection extends EventEmitter {
     let args
     args = (arguments.length >= 1 ? [].slice.call(arguments, 0) : [])
     args.unshift(this.options.namespace)
+    args = args.filter((e) => { return String(e).trim() })
     return args.join(':')
   }
 }

lib/queue.js

@@ -185,6 +185,7 @@ class Queue extends EventEmitter {
     for (var i = 0; i < keys.length; i++) {
       var k = keys[i]
       k = k.replace(this.connection.key(''), '')
+      if (k[0] === ':') { k = k.substr(1) }
       data[k] = values[i]
     }
 

test/core/connection.js

@@ -45,4 +45,13 @@ describe('connection', () => {
     connection.key('thing').should.equal(specHelper.namespace + ':thing')
     connection.end()
   })
+
+  it('removes empty namespace from generated key', async () => {
+    let connectionDetails = specHelper.cleanConnectionDetails()
+    connectionDetails['namespace'] = ''
+    let connection = new NodeResque.Connection(connectionDetails)
+    await connection.connect()
+    connection.key('thing').should.equal('thing')
+    connection.end()
+  })
 })