Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the version number format to make it more easily understandabl… #2829

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

ColdWaterLW
Copy link
Collaborator

@ColdWaterLW ColdWaterLW commented Dec 18, 2024

关联的 issue

actiontech/sqle-ee#2106

描述你的变更

调整Makefile

  1. 如果HEAD存在tag,则GIT_VERSION=<tag> <commit>
    e.g. 3.2411.0 a6355ff4cf8d181315a2b30341bc954b29576b11
    e.g. 3.2412.0-pre1-1 a6355ff4cf8d181315a2b30341bc954b29576b11

  2. 如果HEAD没有tag,则GIT_VERSION=<分支名> <commit>
    e.g. main a6355ff4cf8d181315a2b30341bc954b29576b11

确认项(pr提交后操作)

Tip

请在指定复审人之前,确认并完成以下事项,完成后✅


  • 我已完成自测
  • 我已记录完整日志方便进行诊断
  • 我已在关联的issue里补充了实现方案
  • 我已在关联的issue里补充了测试影响面
  • 我已确认了变更的兼容性,如果不兼容则在issue里标记 not_compatible
  • 我已确认了是否要更新文档,如果要更新则在issue里标记 need_update_doc

assign in @LordofAvernus

@CLAassistant
Copy link

CLAassistant commented Dec 18, 2024

CLA assistant check
All committers have signed the CLA.

@ColdWaterLW ColdWaterLW force-pushed the optimize-version-layout branch from 169638b to 0c41010 Compare December 18, 2024 05:43
Makefile Outdated Show resolved Hide resolved
@ColdWaterLW ColdWaterLW force-pushed the optimize-version-layout branch from 4f2cb6d to 1f4be11 Compare December 18, 2024 07:15
@LordofAvernus LordofAvernus merged commit cae6df8 into main Dec 18, 2024
3 checks passed
@ColdWaterLW ColdWaterLW deleted the optimize-version-layout branch December 18, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants