How to set the body limit for HTTP requests #1089
Open
+7
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #1088, for very large requests (e.g., due to a very large
VALUES
clause), the server currently does not provide a response. In the QLever log, the following error message appears, which originates from a call toboost::beast::http::async_read
:ERROR: body limit exceeded: body limit exceeded
This PR works around this limitation by setting the body limit explicitly in the code. The body limit could easily be made into a command line argument.
Here is a generic query to test whether it works for large requests (with the current master, this request shows the behavior explained above, with this PR it works fine):