Add Dockerfile for CentOS 7.9.2009 #1114
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build the image and run the container as follows: ``` docker build -f Dockerfiles/Dockerfile.centos -t qlever.centos . docker run -it --entrypoint bash --name qlever.centos qlever.centos ``` At that point, all prerequisites have been installed, including g++ 11.3.0, and all the QLever libraries have been compiled. What remains is to link the binaries. The following then produces the same linker errors as reported by the PubChemRDF folks: ``` make ServerMain IndexBuilderMain VERBOSE=1 ```
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1114 +/- ##
==========================================
+ Coverage 80.57% 80.67% +0.10%
==========================================
Files 293 295 +2
Lines 27572 27690 +118
Branches 3385 3385
==========================================
+ Hits 22215 22340 +125
+ Misses 3959 3955 -4
+ Partials 1398 1395 -3 ☔ View full report in Codecov by Sentry. |
added 2 commits
October 1, 2023 06:53
Runs the end-to-end tests in the end, as proof of concept, that indeed everything works now.
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working Dockerfile for CentOS 7.9.2009. Installs
g++ 11.3.0,binutils 2.36(which include a new version ofld), andmold 2.2.0(a more modern linker). Runse2e/e2e.shin the end (QLever's end-to-end test, which builds a small index and sends queries to it from a large test suite), as a proof of concept that indeed everything works as it should.Build the image and run the container as follows:
NOTE: Without the new linkers, we get
defined in discarded sectionerrors during linkin, just like the PubChemRDF folks. The updatedldis only used to compile the newermoldlinker, which is then used to link the Qlever binaries.