-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SPARQL Update Part 1: Located Triples #1379
Conversation
This PR will run somewhat parallel to #1351. To keep it in sync I will cherry-pick the changes made here back to it. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1379 +/- ##
==========================================
+ Coverage 89.06% 89.22% +0.16%
==========================================
Files 328 335 +7
Lines 29294 29722 +428
Branches 3262 3313 +51
==========================================
+ Hits 26090 26519 +429
+ Misses 2054 2045 -9
- Partials 1150 1158 +8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some preliminary comments, haven't looked at everything yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some more comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some additional suggestions and discussions.
@joka921 whats the usual procedure for the coverage of debugging |
It will only be required for the integration.
# Conflicts: # test/util/IdTestHelpers.h
This reverts commit 70757a4.
# Conflicts: # src/index/Permutation.h
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still have some questions, but those can be easily addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one remaining question/suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A little tiny request left:)
|
This is the first PR in a series of PRs that will implement SPARQL UPDATE for QLever.
It implements
LocatedTriples
. These are triples that know to which block in a given permutation they belong to and whether they are to be inserted or deleted. They come with the functionality to find the corresponding blocks for a set of triples (to turn them intoLocatedTriples
as well as the functionality to merge a block from a permutation with all theLocatedTriples
that belong to this block. The latter function is the core functionality to incorporate the results of an UPDATE into subsequent queries.