Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPARQL Update Part 1: Located Triples #1379

Merged
merged 46 commits into from
Jul 18, 2024

Conversation

Qup42
Copy link
Member

@Qup42 Qup42 commented Jun 20, 2024

This is the first PR in a series of PRs that will implement SPARQL UPDATE for QLever.

It implements LocatedTriples. These are triples that know to which block in a given permutation they belong to and whether they are to be inserted or deleted. They come with the functionality to find the corresponding blocks for a set of triples (to turn them into LocatedTriples as well as the functionality to merge a block from a permutation with all the LocatedTriples that belong to this block. The latter function is the core functionality to incorporate the results of an UPDATE into subsequent queries.

@Qup42
Copy link
Member Author

Qup42 commented Jun 20, 2024

This PR will run somewhat parallel to #1351. To keep it in sync I will cherry-pick the changes made here back to it.

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 95.92760% with 9 lines in your changes missing coverage. Please review.

Project coverage is 89.22%. Comparing base (14d6e1c) to head (3d6663f).
Report is 2 commits behind head on master.

Files Patch % Lines
src/index/LocatedTriples.cpp 94.51% 0 Missing and 9 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1379      +/-   ##
==========================================
+ Coverage   89.06%   89.22%   +0.16%     
==========================================
  Files         328      335       +7     
  Lines       29294    29722     +428     
  Branches     3262     3313      +51     
==========================================
+ Hits        26090    26519     +429     
+ Misses       2054     2045       -9     
- Partials     1150     1158       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@joka921 joka921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some preliminary comments, haven't looked at everything yet.

test/LocatedTriplesTest.cpp Show resolved Hide resolved
src/index/LocatedTriples.h Outdated Show resolved Hide resolved
src/index/LocatedTriples.h Show resolved Hide resolved
src/index/LocatedTriples.h Show resolved Hide resolved
src/index/LocatedTriples.h Outdated Show resolved Hide resolved
src/index/LocatedTriples.cpp Outdated Show resolved Hide resolved
src/index/LocatedTriples.cpp Outdated Show resolved Hide resolved
src/index/LocatedTriples.cpp Outdated Show resolved Hide resolved
src/index/LocatedTriples.cpp Outdated Show resolved Hide resolved
src/index/LocatedTriples.cpp Outdated Show resolved Hide resolved
Copy link
Member

@joka921 joka921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some more comments.

src/index/LocatedTriples.cpp Show resolved Hide resolved
src/index/LocatedTriples.cpp Outdated Show resolved Hide resolved
src/index/LocatedTriples.cpp Outdated Show resolved Hide resolved
test/LocatedTriplesTest.cpp Outdated Show resolved Hide resolved
test/LocatedTriplesTest.cpp Outdated Show resolved Hide resolved
test/LocatedTriplesTest.cpp Outdated Show resolved Hide resolved
test/LocatedTriplesTest.cpp Outdated Show resolved Hide resolved
test/LocatedTriplesTest.cpp Show resolved Hide resolved
Copy link
Member

@joka921 joka921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some additional suggestions and discussions.

src/index/LocatedTriples.cpp Outdated Show resolved Hide resolved
src/index/LocatedTriples.cpp Outdated Show resolved Hide resolved
src/index/LocatedTriples.cpp Outdated Show resolved Hide resolved
src/index/LocatedTriples.h Show resolved Hide resolved
src/engine/idTable/IdTableRow.h Outdated Show resolved Hide resolved
src/global/IdTriple.h Outdated Show resolved Hide resolved
src/global/IdTriple.h Outdated Show resolved Hide resolved
src/global/IdTriple.h Outdated Show resolved Hide resolved
src/index/LocatedTriples.cpp Outdated Show resolved Hide resolved
src/index/LocatedTriples.h Outdated Show resolved Hide resolved
@Qup42
Copy link
Member Author

Qup42 commented Jun 24, 2024

@joka921 whats the usual procedure for the coverage of debugging <<s? Write a test only to satisfy or even include a simple testcase?

@Qup42
Copy link
Member Author

Qup42 commented Jul 1, 2024

@joka921 I investigated the build failure on MacOS. The <=> was only implemented for array in libc++ in May 2023 1. I would expect it to available from LLVM 17 (September 2023 2) on, but we're currently building against LLVM 16.

Footnotes

  1. https://reviews.llvm.org/D132265

  2. https://releases.llvm.org/

Copy link
Member

@joka921 joka921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still have some questions, but those can be easily addressed.

src/index/LocatedTriples.cpp Outdated Show resolved Hide resolved
src/global/IdTriple.h Outdated Show resolved Hide resolved
src/index/LocatedTriples.h Outdated Show resolved Hide resolved
src/index/LocatedTriples.h Show resolved Hide resolved
src/index/LocatedTriples.h Outdated Show resolved Hide resolved
src/index/LocatedTriples.cpp Outdated Show resolved Hide resolved
src/index/LocatedTriples.cpp Outdated Show resolved Hide resolved
src/index/Permutation.h Outdated Show resolved Hide resolved
test/IdTripleTest.cpp Outdated Show resolved Hide resolved
test/LocatedTriplesTest.cpp Outdated Show resolved Hide resolved
Copy link
Member

@joka921 joka921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one remaining question/suggestion.

src/index/LocatedTriples.h Outdated Show resolved Hide resolved
Copy link
Member

@joka921 joka921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little tiny request left:)

src/index/LocatedTriples.cpp Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Jul 17, 2024

@joka921 joka921 merged commit ee0e2ac into ad-freiburg:master Jul 18, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants