Correct lexicographic ordering of items from the local vocab #1390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
local Vocab and Vocab. However the sorting between local vocab entries doesn't yet work.
TODO: * Binary search expressions (at least partially). * Fix unit tests * Clean everything up.
Only small things not yet working.
This is still missing comments, and we neeed to discuss and understand the ICU Levels etc.
We really have to fix this...
hannahbast
requested changes
Jul 10, 2024
TODO<joka921> Add a unit test that would have caught this bug.
…parison-local-vocab # Conflicts: # src/index/PatternCreator.cpp
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1390 +/- ##
==========================================
+ Coverage 89.38% 89.51% +0.13%
==========================================
Files 340 342 +2
Lines 29727 29816 +89
Branches 3309 3310 +1
==========================================
+ Hits 26570 26690 +120
+ Misses 1999 1976 -23
+ Partials 1158 1150 -8 ☔ View full report in Codecov by Sentry. |
Next try: store an IndexPointer in the LocalVocabEntries.
TODO: Index building and all the other TODOs.
…nal or external vocabulary.
# Conflicts: # src/index/PatternCreator.cpp # test/index/PatternCreatorTest.cpp
Feed it to the tools.
…local-vocab # Conflicts: # src/index/IndexImpl.cpp # test/IndexTest.cpp
# Conflicts: # src/index/IndexImpl.cpp
hannahbast
requested changes
Jul 26, 2024
hannahbast
approved these changes
Jul 26, 2024
hannahbast
changed the title
hannahbast
changed the title
added 4 commits
July 27, 2024 01:16
Trying out whether not only gcc 13, but also everyone else (including SonarCloud) will be happy with this.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, items from the local vocab were handled as if they were lexicographcally larger than all items from both the internal and external vocabulary. This is now fixed, here is an example query: https://qlever.cs.uni-freiburg.de/wikidata/Fkr5Aa . For efficiency reasons, when an entry from the local vocab is compared with an entry from the original vocab, its lower and upper bound in the original vocab are remembered, in order to make future comparisons cheaper. Together with #1405, which fixes the ordering between words in the internal and external vocabularies, QLever can now correctly handle lexicographic ordering of string literals or IRIs in all cases. This concerns operations like
ORDER BYandFILTERwth string comparisons or prefix searches.