Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a small bug in the Turtle parser #1394

Merged
merged 4 commits into from
Jul 15, 2024

Conversation

joka921
Copy link
Member

@joka921 joka921 commented Jul 11, 2024

Fixes #1392 . The problem occurred for typed literals with escaped characters.

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.09%. Comparing base (14d6e1c) to head (1a1f5f0).
Report is 1 commits behind head on master.

Files Patch % Lines
src/parser/RdfEscaping.cpp 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1394      +/-   ##
==========================================
+ Coverage   89.06%   89.09%   +0.02%     
==========================================
  Files         328      328              
  Lines       29294    29298       +4     
  Branches     3262     3262              
==========================================
+ Hits        26090    26102      +12     
+ Misses       2054     2048       -6     
+ Partials     1150     1148       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Jul 11, 2024

@Qup42
Copy link
Member

Qup42 commented Jul 12, 2024

Thanks. I tested it out by merging into my working branch and the problem is gone. The index builds successfully again and everything seems to work.

Copy link
Member

@hannahbast hannahbast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this fix!

@hannahbast hannahbast merged commit 6a6a4b8 into ad-freiburg:master Jul 15, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Literals with \ cause index build to fail
3 participants