Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Node #31

Merged
merged 2 commits into from
May 6, 2024
Merged

Upgrade Node #31

merged 2 commits into from
May 6, 2024

Conversation

anthony-dandrea
Copy link
Contributor

  • Upgrade to Node v20. This should remove the deprecated warnings in GitHub action job summaries.
    Screenshot 2024-05-03 at 2 22 40 PM
  • Make it so lint & test scripts run & pass.
  • Upgrade to checkout v4 as v3 is now deprecated as well.
  • Needed to add NODE_OPTIONS=--openssl-legacy-provider for the build script for it to work.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024 •
edited
Loading

Coverage Report

  • Status: ✅ Passed
Click to view remaining coverage report
Status File Stmts Branch Funcs
✨ 🆕 com.tubitv.ads.manager.dependency.grpc.VideoTranscodeClient 0 0 0
✨ 🆕 com.tubitv.ads.manager.graphqlapi.routes.AdserverCreativeApiRoutes 0 0 0
✨ 🆕 com.tubitv.ads.manager.init.IngressRouteModule 0 0 0
✨ 🆕 com.tubitv.ads.manager.neo.creatives.routes.CreativeRoutes 0 0 0
✨ 🆕 com.tubitv.adserver.jobs.DateArgExtractor 0 0 0
Total 66.75%
Change from base: 0%
Covered statements: 4933
Total statements: 7390

yuhaoju
yuhaoju approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@yuhaoju yuhaoju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@anthony-dandrea anthony-dandrea added this pull request to the merge queue May 6, 2024
Merged via the queue into main with commit 60f8b4e May 6, 2024
2 checks passed
@anthony-dandrea anthony-dandrea deleted the ugprade-node branch May 6, 2024 14:43
@anthony-dandrea anthony-dandrea mentioned this pull request May 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuhaoju yuhaoju yuhaoju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anthony-dandrea @yuhaoju