Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade jest #28

Merged
merged 3 commits into from
Feb 22, 2024
Merged

upgrade jest #28

merged 3 commits into from
Feb 22, 2024

Conversation

zhiyelee
Copy link
Collaborator

upgrade jest to latest version

@zhiyelee zhiyelee requested a review from nickqi-tubi February 20, 2024 20:03
@coveralls
Copy link

coveralls commented Feb 20, 2024

Pull Request Test Coverage Report for Build 7997322101

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 7979176448: 0.0%
Covered Lines: 98
Relevant Lines: 98

💛 - Coveralls

Copy link

@arunshan arunshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhiyelee why did the dest/index.js change when you update jest? Should that be just a dev dependency?

@zhiyelee
Copy link
Collaborator Author

@zhiyelee why did the dest/index.js change when you update jest? Should that be just a dev dependency?

Good question. It's embarrassing that I forgot to update dest/index.js for the past two releases. The index.js will be used in the action instead of the source code. I realized this when working on this PR and decided to squeeze it in

Copy link

@nickqi-tubi nickqi-tubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The upgrade looks good.

However, I noticed a warning in CI saying that "The set-output command is deprecated and will be disabled soon". So, we may need to upgrade @actions/core or @actions/github in a new PR as well.

Xnip2024-02-21_09-30-07

@nickqi-tubi
Copy link

@zhiyelee why did the dest/index.js change when you update jest? Should that be just a dev dependency?

Good question. It's embarrassing that I forgot to update dest/index.js for the past two releases. The index.js will be used in the action instead of the source code. I realized this when working on this PR and decided to squeeze it in

Do we need to bump up the package version have a new NPM release?

@zhiyelee zhiyelee merged commit 1dc4248 into master Feb 22, 2024
2 checks passed
@zhiyelee zhiyelee deleted the jest_upgrade branch February 22, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants