Breakout room 10 #11
Open
Breakout room 10 #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lisabethu88
reviewed
Dec 16, 2022
| #Displays the story based on the users input | ||
| print ("------------------------------------------") | ||
| print ("Be kind to your",noun,"- footed", plural_noun) | ||
| print ("For a duck may be somebody's", seond_noun,",") |
There was a problem hiding this comment.
seond_noun is misspelled. it should be "second_noun".
There was a problem hiding this comment.
fstrings could be used here to prevent extra spaces before any punctuation
Comment on lines
+2
to
+3
| loop = 1 | ||
| while (loop < 9): |
There was a problem hiding this comment.
The story is supposed to loop 10 times, so we should initialize loop to 0 and change the while condition to <= 9.
Comment on lines
+5
to
+10
| noun = input("Choose a noun: ") | ||
| plural_noun = input("Choose a plural noun: ") | ||
| second_noun = input("Choose a noun: ") | ||
| place = input("Name a place: ") | ||
| adjective = input("Choose an adjective (Describing word): ") | ||
| third_noun = input("Choose a noun: ") |
There was a problem hiding this comment.
Recommend validating input.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.