-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breakout Room 3 #12
base: main
Are you sure you want to change the base?
Breakout Room 3 #12
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to modify the loop to complete 10 iterations and change the second_noun typo. Missing tests from this request. Please provide.
#Displays the story based on the users input | ||
print ("------------------------------------------") | ||
print ("Be kind to your",noun,"- footed", plural_noun) | ||
print ("For a duck may be somebody's", seond_noun,",") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable seond_noun is is a typo and so the program stops working once the second_noun input is provided.
@@ -1 +1,22 @@ | |||
#Mad Libs Generator Project | |||
loop = 1 | |||
while (loop < 9): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This causes the program to end after 8 loops to achieve 10 loops you would want to modify this implementation.
@@ -1 +1,22 @@ | |||
#Mad Libs Generator Project | |||
loop = 1 | |||
while (loop < 9): | |||
#All the questions that the program asks the user |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Input receives all types of data and makes it a string. May want to add checks for other data types to ensure proper story input.
print ("For a duck may be somebody's", seond_noun,",") | ||
print ("Be kind to your",plural_noun,"in",place) | ||
print ("Where the weather is always",adjective,".") | ||
print () |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This blank line makes for in consistent styling. May want to remove.
place = input("Name a place: ") | ||
adjective = input("Choose an adjective (Describing word): ") | ||
third_noun = input("Choose a noun: ") | ||
#Displays the story based on the users input |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To take out unwanted spaces you can convert print statements from (string, input, end) to f"strings" This is the case for the print statements from lines 14, 16, 18. For consistency you can convert all. Could also convert the entire print section to a multiline print statement with all variables inserted and use \n for desired line breaks.
print ("Well it is.") | ||
print ("------------------------------------------") | ||
#Loop back to "loop = 1" | ||
loop = loop + 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could increment with loop += 1 instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please include a test file to make sure the code is behaving as expected.
@@ -1 +1,22 @@ | |||
#Mad Libs Generator Project | |||
loop = 1 | |||
while (loop < 9): | |||
#All the questions that the program asks the user |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The notes make it easier to understand what the different sections of the code are doing.
No description provided.