Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breakout Room 5 #6

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Breakout Room 5 #6

wants to merge 1 commit into from

Conversation

tgoslee
Copy link

@tgoslee tgoslee commented Dec 13, 2022

No description provided.

Copy link
Collaborator

@mckay1818 mckay1818 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start on the madlibs project! I added some specific suggestions for the main.py file, but I would also recommend adding a tests file and testing for edge cases, # of loops, etc.

@@ -1 +1,22 @@
#Mad Libs Generator Project
loop = 1
while (loop < 9):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loop will currently exit after 8 rounds of Mad Libs - reconfigure this so there are 10 rounds

print ("You may think that is this the",third_noun,",")
print ("Well it is.")
print ("------------------------------------------")
#Loop back to "loop = 1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loop starts at the "while" statement on line 3, not line 2. It could be helpful for you to clarify this in your comment!

Comment on lines +12 to +20
print ("------------------------------------------")
print ("Be kind to your",noun,"- footed", plural_noun)
print ("For a duck may be somebody's", seond_noun,",")
print ("Be kind to your",plural_noun,"in",place)
print ("Where the weather is always",adjective,".")
print ()
print ("You may think that is this the",third_noun,",")
print ("Well it is.")
print ("------------------------------------------")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To cut down on print statements, you could consider making this a multi-line string! https://www.w3schools.com/python/gloss_python_multi_line_strings.asp

#Displays the story based on the users input
print ("------------------------------------------")
print ("Be kind to your",noun,"- footed", plural_noun)
print ("For a duck may be somebody's", seond_noun,",")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, all punctuation after user inputted words is separated from those words with a space (lines 14, 16, 18). You could remove these spaces for better readability

Copy link
Collaborator

@ryjpink ryjpink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start on Mad Libs Generator project!! It would also be good to add a test file to make sure your project working as your expectation.

@@ -1 +1,22 @@
#Mad Libs Generator Project
loop = 1
while (loop < 9):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The game should loop so the user can create 10 stories. The while loop can work without round bracket.

Suggested change
while (loop < 9):
while loop < 11:

print ("Well it is.")
print ("------------------------------------------")
#Loop back to "loop = 1"
loop = loop + 1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
loop = loop + 1
loop += 1

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make multiline statements and use f-string in the print function.

#Displays the story based on the users input
print ("------------------------------------------")
print ("Be kind to your",noun,"- footed", plural_noun)
print ("For a duck may be somebody's", seond_noun,",")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
print ("For a duck may be somebody's", seond_noun,",")
print ("For a duck may be somebody's", second_noun,",")

print ("You may think that is this the",third_noun,",")
print ("Well it is.")
print ("------------------------------------------")
#Loop back to "loop = 1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#Loop back to "loop = 1"
#Loop back to "while loop < 11:"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants