-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breakout room 6 #7
base: main
Are you sure you want to change the base?
Conversation
@@ -1 +1,22 @@ | |||
#Mad Libs Generator Project | |||
loop = 1 | |||
while (loop < 9): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like 8 stories are being created at the moment, if we update this line to (loop < 11)
we'll be creating 10 stories as stated in the requirements :)
print ("You may think that is this the",third_noun,",") | ||
print ("Well it is.") | ||
print ("------------------------------------------") | ||
#Loop back to "loop = 1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks that we are increasing the variable loop by one in the code. And I think that comments can mislead the team about actual action.
#Displays the story based on the users input | ||
print ("------------------------------------------") | ||
print ("Be kind to your",noun,"- footed", plural_noun) | ||
print ("For a duck may be somebody's", seond_noun,",") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small typo: second_noun
print ("For a duck may be somebody's", seond_noun,",") | ||
print ("Be kind to your",plural_noun,"in",place) | ||
print ("Where the weather is always",adjective,".") | ||
print () |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add a line break by adding print("\n")
Great code changes, try running the code through our linting process before merging it to main :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good approach with using while loop. I have several suggestions. Please feel free to ask if you have any questions.
third_noun = input("Choose a noun: ") | ||
#Displays the story based on the users input | ||
print ("------------------------------------------") | ||
print ("Be kind to your",noun,"- footed", plural_noun) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Be sure to have spaces between provided text and user's inputs.
adjective = input("Choose an adjective (Describing word): ") | ||
third_noun = input("Choose a noun: ") | ||
#Displays the story based on the users input | ||
print ("------------------------------------------") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove extra white spaces between print and ( so the coding style is matching with input()?
No description provided.