Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breakout room 7 #8

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Breakout room 7 #8

wants to merge 1 commit into from

Conversation

tgoslee
Copy link

@tgoslee tgoslee commented Dec 13, 2022

No description provided.

Copy link
Collaborator

@ctlaultdel ctlaultdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, code looks great - just a few suggestions for formatting and improving readability. It would also be great to see some unit tests implemented. Keep up the great work with more fantastic ada ac2 activities @tgoslee!

print ("Well it is.")
print ("------------------------------------------")
#Loop back to "loop = 1"
loop = loop + 1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not required but you could condense this line to: loop += 1

print ("For a duck may be somebody's", seond_noun,",")
print ("Be kind to your",plural_noun,"in",place)
print ("Where the weather is always",adjective,".")
print ()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of an empty print() statement for a new line - you can simply add \n to the end of the string statement on line 16

loop = 1
while (loop < 9):
#All the questions that the program asks the user
noun = input("Choose a noun: ")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of repeating the input() method for each user input request - you can set up a for loop to reduce the amount of code here (lines 5- 10)

third_noun = input("Choose a noun: ")
#Displays the story based on the users input
print ("------------------------------------------")
print ("Be kind to your",noun,"- footed", plural_noun)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For lines 13 - 19, it would be easier to read if the print statements were all formatted as f strings. Also you could consider the following format to prevent rewriting print():
print(f'string1', f'string2', f'string3')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants