Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breakout room 8 #9

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Breakout room 8 #9

wants to merge 1 commit into from

Conversation

tgoslee
Copy link

@tgoslee tgoslee commented Dec 13, 2022

No description provided.

Copy link
Collaborator

@ciindii ciindii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems great! It would be useful if you added some unit tests. There is one bug that you should fix and a few suggestions to reduce the code.

@@ -1 +1,22 @@
#Mad Libs Generator Project
loop = 1
while (loop < 9):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loop is not running 10 times, its only running 8 times. please make it run 10 times

Suggested change
while (loop < 9):
while (loop <= 10):

print ("For a duck may be somebody's", seond_noun,",")
print ("Be kind to your",plural_noun,"in",place)
print ("Where the weather is always",adjective,".")
print ()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe use /n to start a new line instead of using an empty print statement

print ("Be kind to your",noun,"- footed", plural_noun)
print ("For a duck may be somebody's", seond_noun,",")
print ("Be kind to your",plural_noun,"in",place)
print ("Where the weather is always",adjective,".")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
print ("Where the weather is always",adjective,".")
print ("Where the weather is always",adjective,"./n")

Copy link
Collaborator

@nadxelleHernandez nadxelleHernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. I left some suggestions for you to check. There is one bug that needs fixing.
I would also suggest to write some input validation function to check for empty strings or invalid words (numbers or symbols)

#Displays the story based on the users input
print ("------------------------------------------")
print ("Be kind to your",noun,"- footed", plural_noun)
print ("For a duck may be somebody's", seond_noun,",")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have a typo on the variable second_noun

Suggested change
print ("For a duck may be somebody's", seond_noun,",")
print ("For a duck may be somebody's", second_noun,",")

adjective = input("Choose an adjective (Describing word): ")
third_noun = input("Choose a noun: ")
#Displays the story based on the users input
print ("------------------------------------------")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the line of dashes that separate the story from the inputs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants