-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breakout room 8 #9
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything seems great! It would be useful if you added some unit tests. There is one bug that you should fix and a few suggestions to reduce the code.
@@ -1 +1,22 @@ | |||
#Mad Libs Generator Project | |||
loop = 1 | |||
while (loop < 9): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
loop is not running 10 times, its only running 8 times. please make it run 10 times
while (loop < 9): | |
while (loop <= 10): |
print ("For a duck may be somebody's", seond_noun,",") | ||
print ("Be kind to your",plural_noun,"in",place) | ||
print ("Where the weather is always",adjective,".") | ||
print () |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe use /n to start a new line instead of using an empty print statement
print ("Be kind to your",noun,"- footed", plural_noun) | ||
print ("For a duck may be somebody's", seond_noun,",") | ||
print ("Be kind to your",plural_noun,"in",place) | ||
print ("Where the weather is always",adjective,".") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
print ("Where the weather is always",adjective,".") | |
print ("Where the weather is always",adjective,"./n") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. I left some suggestions for you to check. There is one bug that needs fixing.
I would also suggest to write some input validation function to check for empty strings or invalid words (numbers or symbols)
#Displays the story based on the users input | ||
print ("------------------------------------------") | ||
print ("Be kind to your",noun,"- footed", plural_noun) | ||
print ("For a duck may be somebody's", seond_noun,",") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have a typo on the variable second_noun
print ("For a duck may be somebody's", seond_noun,",") | |
print ("For a duck may be somebody's", second_noun,",") |
adjective = input("Choose an adjective (Describing word): ") | ||
third_noun = input("Choose a noun: ") | ||
#Displays the story based on the users input | ||
print ("------------------------------------------") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the line of dashes that separate the story from the inputs
No description provided.