Ocelots - Larissa and Soumya #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sting a new customer
…e attr to be changed
Wave 1: LA-costumer-model
…id to validate_model. Some more refactoring to make the tests pass.
Pull request : Wave 01
…uest and validate_put_request into validate_request.
Wave 1 tests passing.
test wave 3 updates from kyra
Wave 1 and Wave 2 tests are passing!
…t_count in response dict to pass tests
…into ss-videos-model
…into ss-videos-model
Wave 3 tests
wave 3 tests are passing!
| customer_id = db.Column(db.Integer, db.ForeignKey("customer.id")) | ||
| video = db.relationship("Video", back_populates="rentals") | ||
| video_id = db.Column(db.Integer, db.ForeignKey("video.id")) |
There was a problem hiding this comment.
Nice job setting up the relationships, here
| from app.models.validation import validate_model, validate_request, validate_and_process_query_params, create_model_query | ||
|
|
||
| # ~~~~~~ initialize customers blueprint ~~~~~~ | ||
| customers_bp = Blueprint("customers", __name__, url_prefix="/customers") |
There was a problem hiding this comment.
Really nice job refactoring routes to individual files!
|
|
||
|
|
||
| # ~~~~~~ validation checkers and processing functions ~~~~~~ | ||
| def validate_model(cls, model_id): |
There was a problem hiding this comment.
Really nice job refactoring here and organizing this code so nicely!
| join_query = join_query.order_by(sort) | ||
| else: | ||
| # default sort is ascending rental id | ||
| join_query = join_query.order_by(Rental.id.asc()) |
There was a problem hiding this comment.
nice use of SQLAlchemy's OOP interface for sorting :)
| new_rental = Rental.from_dict(request_body) | ||
|
|
||
| new_rental.customer = customer | ||
| new_rental.customer.videos_checked_out_count += 1 |
There was a problem hiding this comment.
Great example making use of the relationships you've set up, to be able to cleanly use SQLAlchemy's OOP interface!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.