Ocelots Anna Du #20
Open
Ocelots Anna Du #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| rentals = db.relationship("Rental", back_populates="customer") | ||
|
|
||
|
|
||
| def to_dict(self): |
| check_out_status = db.Column(db.Boolean,default = True) | ||
| available_inventory = db.Column(db.Integer) | ||
| customer = db.relationship("Customer", back_populates="rentals") |
There was a problem hiding this comment.
Nice job setting up the rental relationships!
| customer = validate_model(Customer, id) | ||
|
|
||
| video_query = Rental.query.filter_by(customer_id=customer.id).join(Video) | ||
| sort_query = request.args.get("sort") |
There was a problem hiding this comment.
Good use of joining tables!
I will add that thanks to the relationships you've set up, you could use the OOP-style SQLAlchemy to get some of this information. Such as customer.rentals :)
|
|
||
| available_inventory = video.total_inventory - videos_checked_out | ||
| if available_inventory == 0: | ||
| abort(make_response({"message":f"Could not perform checkout"}, 400)) |
There was a problem hiding this comment.
When I see repeated code, I think about added cost of maintenance. In this case, I would wonder if there's a way to extract repeated code. Maybe at least defining the error string as a variable, so you only have to make changes in one location. :)
| customer = validate_model(Customer, request_body["customer_id"]) | ||
| video = validate_model(Video, request_body["video_id"]) | ||
|
|
||
| rental = db.session.query(Rental).filter_by(video_id=video.id, customer_id=customer.id).first() |
There was a problem hiding this comment.
This is another example where you might be able to make use of OOP-style SQLAlchemy interfaces, here :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.