Ocelots - McKay #16
Ocelots - McKay #16
Conversation
| @@ -54,13 +54,14 @@ def test_friends_unique_movies_not_duplicated(): | |||
|
|
|||
| # Assert | |||
| assert len(friends_unique_movies) == 3 | |||
|
|
|||
| raise Exception("Test needs to be completed.") | |||
| assert INTRIGUE_3 in friends_unique_movies | |||
There was a problem hiding this comment.
Nice job testing the content, as well
| @@ -1,23 +1,121 @@ | |||
| # ------------- WAVE 1 -------------------- | |||
|
|
|||
| from shutil import move | |||
There was a problem hiding this comment.
I am actually not sure how this line got into my code! I had never heard of the shutil module until noticing this comment, so this is as much a mystery to me as it is to you!
| def create_movie(title, genre, rating): | ||
| pass | ||
| if title and genre and rating: |
There was a problem hiding this comment.
Good job making use of "truthiness" to validate against "" and None here
| return user_data | ||
|
|
||
| def watch_movie(user_data, title): | ||
| for movie in user_data["watchlist"]: |
There was a problem hiding this comment.
Note, while this may work here, it's considered dangerous practice to modify the content of a data structure that you're looping over. Especially in more complex code, this can open you up to complex errors. A simple alternative here could be to save a copy of what you get from movie in user_data["watchlist"] and iterate over that, so that as you modify user_data["watchlist"], there's no risk.
There was a problem hiding this comment.
I think it would be helpful for me to talk through what this alternative would look like in code. Just flagging here that I'll probably swing by your office hours next week to ask about this!
| num_of_movies = len(user_data["watched"]) | ||
| for movie in user_data["watched"]: | ||
| total_rating_score += movie["rating"] | ||
| if num_of_movies == 0: |
| else: | ||
| genres[movie["genre"]] = 1 | ||
| #review this concept | ||
| return max(genres, key=genres.get) |
There was a problem hiding this comment.
Nice use of max() plus using the dict.get() as key to sort your dict!
| return total_rating_score / num_of_movies | ||
|
|
||
| def get_most_watched_genre(user_data): | ||
| genres = {} |
There was a problem hiding this comment.
Nice use of a dict as part of your data processing
|
|
||
| # ----------------------------------------- | ||
| # ------------- WAVE 3 -------------------- | ||
| # ----------------------------------------- | ||
|
|
||
| def get_unique_watched(user_data): |
There was a problem hiding this comment.
Could sets have been an alternate to the nested loop logic in these functions?
No description provided.