Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing unnecessary inline qualify to pure virtual function #545

Merged
merged 1 commit into from
Oct 22, 2023
Merged

Removing unnecessary inline qualify to pure virtual function #545

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions include/ada/url_base.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,8 @@ struct url_base {
* @return On failure, it returns zero.
* @see https://url.spec.whatwg.org/#host-parsing
*/
virtual ada_really_inline size_t
parse_port(std::string_view view, bool check_trailing_content) noexcept = 0;
virtual size_t parse_port(std::string_view view,
bool check_trailing_content) noexcept = 0;

virtual ada_really_inline size_t parse_port(std::string_view view) noexcept {
return this->parse_port(view, false);
Expand Down
Loading