-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
have the C++ compiler generate the tables. #556
Conversation
To be honest, since I also believe it won't affect performance, I would merge this. Even if you did it for fun I actually think it improves readability of the code: rather than manually review the code it is easier to spot which elements are set to true and why. WDYT? |
I don’t disagree but we need to investigate the CI issues. At least one is unrelated to this PR, and I will examine it soon. The performance should be identical, but we should check that it is before merging, as an abundance of caution. |
@anonrig This could be merged. Note that if you have an old compiler with partial support for C++17, this code might break it. We require genuine C++17 support. |
@anonrig I don't know how to fix the linter errors. I ran clang-format on the code. |
@anonrig I think I fixed the linter issue by reverting clang-format to version 14. Indeed, clang-format is version specific. |
@anonrig All reasonable comments. |
@anonrig Code updated. |
@anonrig Might be good now. |
Instead of having hard-coded tables, we can ask the C++ to generate them.
There is no obvious performance degradation (benchdata, LLVM 14).
cc @ShogunPanda