Fix check segment_result range(for node issue #51514) #581
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an intermittent issue identified by @danfuzz in nodejs/node#51514
Reproudction
Code Example
Expected
Raise an error and stop parse.
Actual
Successfully parsed.
Reason
This is an edge case,
segment_result
should not be equal to the size of remaining bits.ada/src/url.cpp
Lines 64 to 83 in 4814d2f