Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use docker so that you can clang-format using version 15 everywhere you are. #585

Merged
merged 5 commits into from
Feb 16, 2024

Conversation

lemire
Copy link
Member

@lemire lemire commented Jan 30, 2024

The current linting script depends on the available clang-format version. Unfortunately, clang-format changes how it formats code between different versions. (They say that they try not to, but they do, as you can easily verify.)

What can you do?

Use docker.

@lemire lemire requested a review from anonrig January 30, 2024 23:23
@lemire lemire marked this pull request as draft January 31, 2024 22:47
@lemire
Copy link
Member Author

lemire commented Jan 31, 2024

To be improved.

@lemire lemire marked this pull request as ready for review February 2, 2024 21:10
@lemire
Copy link
Member Author

lemire commented Feb 2, 2024

@anonrig Please review.

@lemire lemire merged commit 201dd98 into main Feb 16, 2024
66 checks passed
@lemire lemire deleted the docker_clang_format branch February 16, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant