Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent missing python warning when format feature not requested #636

Merged
merged 1 commit into from
Apr 28, 2024

Conversation

iamtimmy
Copy link
Contributor

When consuming this library through fetch-content, cmake warns about missing python on my system.

… warning when python is not found, even when the linting and format checks should not run.
@anonrig anonrig requested a review from lemire April 28, 2024 14:31
@anonrig
Copy link
Member

anonrig commented Apr 28, 2024

I think we should just remove it from cmake. For the time being, I'll merge this.

@anonrig anonrig merged commit 1a80915 into ada-url:main Apr 28, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants