Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add git to aarch64 container in CI #652

Merged
merged 10 commits into from
May 14, 2024
Merged

fix: add git to aarch64 container in CI #652

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
fd616cd
fix: add git to aarch64 container in CI
lemire May 10, 2024
d6f6e38
add permissions
anonrig May 10, 2024
ac92a91
set ctest timeout
anonrig May 10, 2024
e709ee7
fix: keep just sanitizers
lemire May 11, 2024
4f335c0
Update CMakeLists.txt
lemire May 11, 2024
aa3b424
Update aarch64.yml: simplify as much as possible.
lemire May 11, 2024
db1d696
Update aarch64.yml: reenable sanitizer
lemire May 12, 2024
f01a2e8
Update CMakeLists.txt
anonrig May 12, 2024
61179dc
fix: try without leak detection
lemire May 14, 2024
f00ffe2
fix: use bound checker
lemire May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions .github/workflows/aarch64.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ on:
- '**.md'
- 'docs/**'

permissions:
contents: read

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true
Expand All @@ -22,7 +25,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
shared: [ON, OFF]
shared: [OFF]
steps:
- uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # v4.1.4
- uses: uraimo/run-on-arch-action@v2
Expand All @@ -33,11 +36,11 @@ jobs:
with:
arch: aarch64
githubToken: ${{ github.token }}
distro: ubuntu_latest
distro: ubuntu22.04
install: |
apt-get update -q -y
apt-get install -y cmake make g++ ninja-build
apt-get install -y cmake make g++ ninja-build git
run: |
cmake -DADA_SANITIZE=ON -DADA_DEVELOPMENT_CHECKS=ON -DBUILD_SHARED_LIBS=${{matrix.shared}} -G Ninja -B build
cmake --build build -j=2
cmake -DADA_SANITIZE=ON -DBUILD_SHARED_LIBS=${{matrix.shared}} -B build
cmake --build build
ctest --test-dir build
1 change: 1 addition & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ if(ADA_TESTING OR ADA_BENCHMARKS OR ADA_TOOLS)

if (ADA_TESTING AND NOT EMSCRIPTEN)
if(Git_FOUND)
set(CTEST_TEST_TIMEOUT 5)
message(STATUS "The tests are enabled.")
add_subdirectory(tests)
else()
Expand Down
13 changes: 7 additions & 6 deletions tests/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,13 @@ else()
target_link_libraries(ada_c PRIVATE simdjson GTest::gtest_main)
target_link_libraries(url_search_params PRIVATE simdjson GTest::gtest_main)

gtest_discover_tests(wpt_tests)
gtest_discover_tests(url_components)
gtest_discover_tests(basic_tests)
gtest_discover_tests(from_file_tests)
gtest_discover_tests(ada_c)
gtest_discover_tests(url_search_params)
gtest_discover_tests(wpt_tests PROPERTIES TEST_DISCOVERY_TIMEOUT 600)
gtest_discover_tests(wpt_tests DISCOVERY_MODE PRE_TEST)
anonrig marked this conversation as resolved.
Show resolved Hide resolved
gtest_discover_tests(url_components PROPERTIES TEST_DISCOVERY_TIMEOUT 600)
gtest_discover_tests(basic_tests PROPERTIES TEST_DISCOVERY_TIMEOUT 600)
gtest_discover_tests(from_file_tests PROPERTIES TEST_DISCOVERY_TIMEOUT 600)
gtest_discover_tests(ada_c PROPERTIES TEST_DISCOVERY_TIMEOUT 600)
gtest_discover_tests(url_search_params PROPERTIES TEST_DISCOVERY_TIMEOUT 600)

if("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU")
if (CMAKE_CXX_COMPILER_VERSION VERSION_LESS 9)
Expand Down
Loading