Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dictionary to run with fuzzers #660

Merged
merged 3 commits into from
May 16, 2024

Conversation

CarlosEduR
Copy link
Member

Relates to: #658

@@ -0,0 +1,2 @@
"https://"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should add all types of protocols (available as special schemes in url spec)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll do it

@anonrig
Copy link
Member

anonrig commented May 16, 2024

Is there anything that needs to be done to pass the dict to the fuzzer?

@CarlosEduR
Copy link
Member Author

Is there anything that needs to be done to pass the dict to the fuzzer?

From what I was reading here, looks we just need this .options file.
image

I saw some other examples, just updating the build.sh to copy these files too and we should be fine. But let's see...
https://github.com/google/oss-fuzz/blob/ad88a2e5295d91251d15f8a612758cd9e5ad92db/projects/expat/build.sh

@CarlosEduR
Copy link
Member Author

CarlosEduR commented May 16, 2024

@anonrig would you like to set a max value here?
image

From examples, expat defined one but other projects were not.
image

@anonrig
Copy link
Member

anonrig commented May 16, 2024

We can do 1024

@anonrig anonrig marked this pull request as ready for review May 16, 2024 02:30
@anonrig anonrig merged commit f6d5cbd into ada-url:main May 16, 2024
67 checks passed
@CarlosEduR
Copy link
Member Author

@anonrig have you noticed any difference since last run? I haven't

@anonrig
Copy link
Member

anonrig commented May 16, 2024

@anonrig have you noticed any difference since last run? I haven't

I haven't as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants