Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(ffi/ada_free_owned_string): c parameter is passed by value (#65)
* fix(ffi/ada_free_owned_string): c parameter is passed by value While working on #63, I noticed that my Drop wasn't correctly working because the Rust Implementation was assuming that the C parameters are passed by pointer, while they are actually passed by value Then on a deeper check of the C code, found it at https://github.com/ada-url/ada/blob/1227f60798b05a04412af867d2f13ed20ead9243/include/ada_c.h#L53C6-L53C27. BREAKING CHANGE: ada_free_owned_string parameter pass by value * test(ffi/ada_free_owned_string): add Add a single test case for ada_free_owned_string This way, the provided function is always present and always used in the codebase. Test case is based on the previously present test case for idna_to_ascii * style(ffi/tests): format Had not previously formatted the code
- Loading branch information