Use timestamp #51
Use timestamp #51
Conversation
|
Looking at this again this week! I do think there's a way to do this on a per-handler basis that I can try out and suggest if it works. But this is a super helpful PR to have this option! |
|
@tekktrik or any @adafruit/circuitpythonlibrarians have a moment to take a look at this? I have a project that I'm including this functionality in that I'd love to be able to use an official build of this library for instead of my modified branch. I'm willing to make any changes that are desired in order to get it moved in. |
| @@ -92,6 +92,7 @@ def write(self, buf: str) -> int: | |||
| "StreamHandler", | |||
| "logger_cache", | |||
| "getLogger", | |||
| "useTimestamp", | |||
There was a problem hiding this comment.
This doesn't look a like a standard CPython API because it isn't here: https://docs.python.org/3/library/logging.html#module-level-functions
How would you do it in CPython? Please match that.
|
Closing in favor of #61 |
adds
logging.useTimestamp(True)which will usetime.localtime()and a formatted timestamp in the emitted records instead of the defaulttime.monotonic()As a future improvement it could support more configuration of formatting for the timestamp which I believe the CPYthon implementation does have.
I'm not 100% certain that the way I've implemented this functionality is the best. I had initially hoped to add it as an argument to the constructor for the handler. But it turns out that the function
_logRecordFactory()contains the initial creation of the record which is one spot where it needs to choose what type of value to use. Since that function is outside of the classes by itself I couldn't figure out a way to use an argument like I had hoped.