Use with in examples, remove close in json() #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justmobilize
force-pushed
the
with-updates
branch
from
bdf612d
to
d4d03eb
Compare
justmobilize
commented
Apr 20, 2024
| @@ -321,7 +321,7 @@ def json(self) -> Any: | |||
| obj = json_module.load(self._raw) | |||
| if not self._cached: | |||
| self._cached = obj | |||
| self.close() | |||
|
|
|||
There was a problem hiding this comment.
Removed the .close() here, as it's not standard in CPython
| try: | ||
| fitbit_json = fitbit_get_response.json() | ||
| with requests.get(url=FBIS, headers=FBH) as fitbit_get_response: |
There was a problem hiding this comment.
A few of these, I moved the initial connection into the try/except block
Comment on lines
-95
to
-96
| github_response.close() | ||
| print("✂️ Disconnected from Github API") |
There was a problem hiding this comment.
Removed these closes, and the disconnected message
|
Wow, thank you. Saved me from all these changes. 🙏 |
FoamyGuy
approved these changes
Apr 27, 2024
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Apr 28, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k to 6.0.0 from 5.2.1: > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#150 from pinkavaj/pi-fix-sock-exit > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#160 from justmobilize/remove-wsgiserver Updating https://github.com/adafruit/Adafruit_CircuitPython_ConnectionManager to 1.2.0 from 1.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_ConnectionManager#13 from justmobilize/close-all-and-counts Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 3.2.6 from 3.2.5: > Merge pull request adafruit/Adafruit_CircuitPython_Requests#188 from justmobilize/with-updates Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the examples to use
with request.method as response:and removed the close in theResponse.json()as it doesn't match CPythonTested the wifi standard and advanced and the rocketlive in advanced
fixes #186