handle servers that omit a space after a colon in response headers #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If possible please tag a release after merging this example, it's required for an in progress guide. |
|
Should we add a test, to make sure it doesn't accidentally get reset? |
FoamyGuy
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
This looks good to me.
@justmobilize We could add a test for it, but I don't necessarily think we need to have it before merging this and allowing the learn guide to be unblocked.
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jul 9, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_SD to 3.3.23 from 3.3.22: > Merge pull request adafruit/Adafruit_CircuitPython_SD#58 from arturo182/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 4.1.4 from 4.1.3: > Merge pull request adafruit/Adafruit_CircuitPython_Requests#200 from adafruit/no-space-after-colon Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example URL: "http://ice2.somafm.com/dronezone-128-mp3"