Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup pin definitions for UART + Analog #120

Merged
merged 4 commits into from
Oct 2, 2023
Merged

Conversation

tyeth
Copy link
Contributor

@tyeth tyeth commented Sep 11, 2023

Removes duplicate pin and fixes order in QT Py ESP32 Pico.
Specify all PWM pins as servo+pwm compatible.
Restrict Feather ESP32 v1 A2-A4 input only

Removes duplicate pin and fixes order in QT Py ESP32 Pico.
Specify all PWM pins as servo+pwm compatible.
Restrict Feather ESP32 v1 A2-A4 input only
@tyeth tyeth requested a review from brentru September 13, 2023 15:40
@tyeth
Copy link
Contributor Author

tyeth commented Sep 13, 2023

@brentru double checked, think I got them all

Copy link
Member

@brentru brentru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some questions to resolve, then we can merge in. Excellent job on adding missing links to documentation while you were in the .json files!

boards/qtpy-esp32s2/definition.json Show resolved Hide resolved
@tyeth tyeth requested a review from brentru September 19, 2023 11:25
@lorennorman lorennorman merged commit 3decbbf into main Oct 2, 2023
7 checks passed
@lorennorman lorennorman deleted the update-uart-pins branch October 2, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants