fixed build for python3 #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There were several improvement in #108. Please check if this is still an issue. |
|
@poopgiggle Thanks for the pull request. @MatthewWest made several improvements in #108 and I don't believe Python 3 should be an issue anymore. Could you please confirm this? |
|
tbh I haven't used this package in a long time (almost 2 years now I guess), and in fact I forgot I opened this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed so that it will build on python3. Perhaps consider adding another branch?
Also moved a declaration to beginning of the function to fix an error that is thrown with some compiler configurations.
Had to comment out SPI in setup.py to get it to build.